-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log format fields may not be clear #6914
Comments
I've updated the log formats section here to include details abut the log-level codes: What other information do we want to include about the fields in different log formats? Depending on what other information we need, the organization of this info might change, particularly if we explain all fields for each format. |
@dmuelle Looks good, just a minor type where there is an extra ":" after A and E. Regarding the different fields for each log format, I suggest we can specify the "Template" of how the message would look like based on the different log format and provided the example for each format. It would be more clear to users on the contents of the logs based on the different log formats. For example, something like the following: Similarly, for Simple/TBASIC log format: For JSON, Enhanced, Advanced, are self-explanatory, since the corresponding fields have field names, as well as, JSON format has its own section. |
Thanks @pgunapal - I've updated the format descriptions with a "template" for simple and tbasic I'm not sure if we should include more info for Enhanced and Advanced- although the enhanced has field names, both these formats contain elements that are not addressed by the current descriptions and I wasn't sure how to define/explain them. Let me know what you think. Thanks! |
@dmuelle The field names in the Enhanced format are components from the Log Record for that particular trace message, that provided additional details about the trace message. It contains the type of the message, the date and time, messageID, fully qualified classname, severity level, log level, method name, classname, level value, thread name, correlationID, or, product, component, message and objectID. For Advanced, it is similar to Enhanced, but the format is similar to how the Advanced traceFormat in traditional WAS is. It preserves more specific trace information. |
Thanks @pgunapal - i've updated the draft:
If any further edits are needed, just let me know. When you're satisfied with the update, you can add the |
Looks good, added the |
Hi @ramkumar-k-9286 - this update is ready for peer review. Only the linked section of the doc needs review. |
Peer ReviewThe log format has an anchor and is linked in the beginning, but JSON logging is not. Should it not be linked? For example, you might choose to output your messages log in JSON format if it is consumed by a log analysis platform. Acrolinx suggestion - consumed -> used - simpler usage. I see that the file name is [AUDIT ] CWWKF0011I: The defaultServer server is ready to run a smarter planet. The defaultServer server started in 7.967 seconds. in the code-block [AUDIT] -> is not showing up correctly (square brackets). For more information, see JSON logging. In this example, the For more information about TBASIC, see TBASIC log format. Messages in Acrolinx -> replace additional with more. Q: -> ...thread name, correlationID (or product, component, message**,** and objectID). -> is the or placed correctly? Messages that are in DEV format print the full log-level name before the message ID code. Messages that are in JSON or ENHANCED format include a loglevel property that identifies the message log level. Messages that are in SIMPLE or TBASIC format include one of the following message log-level attributes directly before the message ID code: Info messages are written to the system output stream. I saw that log level is mentioned in 2 ways across the document: log level and log-level - Which one should be used? The TBASIC logging format provides a consistent log format across your Open Liberty console, message, and trace log files. The You can also specify the TBASIC log format for the messages and console logs as an environment variable in your |
Thanks for reviewing- all suggestions implemented except:
"Info" is the message type
yes, the latter three are an alternative to the first
log-level is used when the term is a compound adjective describing the attributes, otherwise "log level". |
Document: Log and trace configuration
http://openliberty.io/docs/latest/log-trace-configuration.html
A question was posed by a user as to what the I, A, O letters stand for when the SIMPLE (default) log format is used.
It does not seem as though we explain the log formats, but rather only provide an example. Therefore it may not be clear as to what the various parts of some of the formats represent (like the
consoleLogLevel
represented by the first letter of the valid values).The text was updated successfully, but these errors were encountered: