-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication in Open Liberty #893
Comments
@lauracowen I can't access either of the box notes above- the second appears to be expired and I don't have permission to the first- if another link is available can you share with me? The KC resources are helpful but I need to know what is specific to OL. I'm going to work through the |
Oops, sorry. The first was to the Intro to Security MP4 video and the second is the slides to that video. You can find them both in here: https://ibm.box.com/s/wokyhx7j1yr8883ehpdcnj2irzvao1xx (intranet only - sorry, the external links now expire quickly). The presentation was given to customers and anyone interested at the end of last year, I think. |
Worth watching the intro to security video to get a general overview of what liberty security is about. Most of it is relevant to cloud deployments (though it doesn't specifically talk about that). |
Draft up for review at Awaiting links to other docs (SSO topics) currently in development |
Added suggested edits from Bruce Tiffany and put in a diagram mock-up. Diagram will need to be cleaned up once the content is approved |
@dmuelle Peer review feedback:
I think you did a really nice job introducing what authentication is and framing it in the context of cloud-native microservice development (i.e., what it means for OL users). |
Thanks for this review @Charlotte-Holt - the issues you've raised are addressed in this PR- #977 |
NIce! Thank you. Couple of comments:
|
Thanks @lauracowen - these issues are addressed in this PR- #981 |
Draft up for review at |
Updates per Ajay Reddy review:
|
Other than that, the topic looks great. Thank you. |
|
Great, thanks. There's not a lot we can do about the javadoc immediately but we can work on that separately. Aside from the diagram, I think this is good to go. |
@lauracowen the new diagram from design is now on the draft site- let me know if it needs any further tweaking. Otherwise this should be ready to publish with the rest of the security topics? https://draft-openlibertyio.mybluemix.net/docs/ref/general/#authentication.html |
Pretty! :) I'm going to assume it's technically correct so if it's now there, I'm happy for this to be queued up with the rest of the security docs. Thanks |
yup- this is the same one that Bruce et al signed off on in the one liberty slack discussion, just fitted and finished. I'll mark it ready to publish |
Requested final peer review from @rw2513 |
This is a well-written topic, I just have a couple comments:
|
Thanks @Rwalls1 - I've updated the topic to fix that sentence and repair the broken links https://draft-openlibertyio.mybluemix.net/docs/ref/general/#authentication-open-liberty.html |
@dmuelle looks good! |
issues addressed in new editing pass:
|
Hi David, Nice job with the topic! I have a few comments:
|
@chirp1 thanks for reviewing. I made the following changes per your review: https://draft-openlibertyio.mybluemix.net/docs/20.0.0.11/authentication.html
|
comments from @utle in 2746: https://draft-openlibertyio.mybluemix.net/docs/20.0.0.11/authentication.html
The SSO article have:
|
@utle thanks for reviewing:
|
Hi David,
|
@chirp1 thanks for reviewing. I made the following changes to the draft:
|
Hi!
|
@chirp1 - made the following changes per your review:
https://draft-openlibertyio.mybluemix.net/docs/20.0.0.11/authentication.html |
@dmuelle Hi David, I spotted another item to comment on:
|
@chirp1 I think although a database could be a web service, in most cases the application communicates with an API, which would in turn communicate with the DB. I've updated the sentence to be more clear:
|
It's a tough topic to explain well, and all of you collaborated and did a good job on it. Hooray!! |
Thanks @brutif - it's nice to get nice feedback :) |
From LC: This is a new concept topic about authentication in Open Liberty. Authentication verifies who the user is. User ID and password (user registry - link to separate topic), SSO (LTPA, OpenID Connect, SAML, JWT, Social login, SPNEGO - link to separate topics because only one or two of them will be relevant to any given reader so they can ignore the ones they're not interested in). Users of apps running on OL can use their social media accounts (using OAuth and Open ID standards) to log into the apps. If multiple options are presented with a form to select which (give example screenshot to illustrate?). Out of the box, apps can be configured to enable users to use Facebook, Twitter, GitHub, LinkedIn, and Google, but others can be added. Once the user has authenticated, show how an app can find out who the person is.
The authentication topic in the KC provides a bit of an intro but it needs more. First introduce the concept of authentication on Open Liberty needs to be introduced first Introduce what JAAS (Java Authentication and Authorization Service) is and how it is used in authentication processes.
A diagram is needed but I don't know whether the one in this topic is a good one to use or not - probably needs updating for the context of microservices - ideally using one of our existing scenarios such as the system properties or the music store.
The text was updated successfully, but these errors were encountered: