Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BeanValidationDiagnosticsCollector: Use qualified names and equals() for checking built-in types. #1039

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

mrglavas
Copy link
Contributor

Resolves #1027

Also removed unused constants for unqualified class names.

Signed-off-by: Michael Glavassevich <mrglavas@ca.ibm.com>
Signed-off-by: Michael Glavassevich <mrglavas@ca.ibm.com>
@TrevCraw
Copy link
Contributor

@mrglavas All builds are failing. Have you checked to see if these are existing failures or new ones?

@mrglavas
Copy link
Contributor Author

@mrglavas All builds are failing. Have you checked to see if these are existing failures or new ones?

@TrevCraw I restarted all of the failing jobs. I'll take a look once they're done again. I did run the Jakarta unit test bucket locally for each of these PRs and those were passing before I put these up for review.

@mrglavas
Copy link
Contributor Author

@mrglavas All builds are failing. Have you checked to see if these are existing failures or new ones?

@TrevCraw I restarted all of the failing jobs. I'll take a look once they're done again. I did run the Jakarta unit test bucket locally for each of these PRs and those were passing before I put these up for review.

@TrevCraw Linux is passing now. Was seeing "Timed out waiting for message CWWKE0036I in log:/home/runner/work/liberty-tools-intellij/liberty-tools-intellij/liberty-tools-intellij/src/test/resources/projects/maven sample/singleModMavenMP/target/liberty/wlp/usr/servers/defaultServer/logs/messages.log" in the previously failed build which I believe is a known issue (#982) that we're tracking. The Mac and Windows failures look like the known problems too.

@mrglavas mrglavas merged commit 231ea9e into OpenLiberty:main Oct 28, 2024
1 of 3 checks passed
@mrglavas mrglavas deleted the 1027#qualified-names branch October 28, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants