#1131 extra dialog appears for multiple projects #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staicy123
requested review from
vaisakhkannan,
mrglavas,
TrevCraw and
turkeylurkey
vaisakhkannan
requested changes
Nov 27, 2024
src/main/java/io/openliberty/tools/intellij/util/TreeDataProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/io/openliberty/tools/intellij/runConfiguration/LibertyRunConfiguration.java
Outdated
Show resolved
Hide resolved
vaisakhkannan
previously approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Thanks @staicy123 , Changes looks good to me.
I have tested these changes using zip file generated in intellij versions 2024.1, 2024.2 and 2024.3. So works fine as expected in all 3 IDEs
turkeylurkey
requested changes
Nov 27, 2024
src/main/java/io/openliberty/tools/intellij/actions/LibertyGeneralAction.java
Outdated
Show resolved
Hide resolved
staicy123
force-pushed
the
#1131-Extra-Dialog-Appears-for-multiple-projects
branch
from
b74ed41
to
831f833
Compare
…ATAKEY and added comments
vaisakhkannan
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##1131
This PR addresses the issue where a behavioral inconsistency was identified in DevMode actions from the Liberty Tool window between IntelliJ versions 2024.1 and 2024.2 (with the same behavior observed in 2024.3). Specifically, an unnecessary pop-up window was appearing to select the Liberty project, even when the DevMode for the corresponding project was already selected.
The root cause of the issue was identified and resolved. The fix ensures that the extra pop-up no longer appears, streamlining the workflow for the affected IntelliJ versions.