Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audit logs support to MpTelemetry-2.0 #30013

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Add Audit logs support to MpTelemetry-2.0 #30013

merged 10 commits into from
Dec 5, 2024

Conversation

pgunapal
Copy link
Member

@pgunapal pgunapal commented Oct 30, 2024 •
edited
Loading

Part of #29229

@pgunapal pgunapal changed the title Adding Audit logs support to MpTelemetry-2.0 Add Audit logs support to MpTelemetry-2.0 Oct 30, 2024
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 4 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@pgunapal pgunapal marked this pull request as ready for review November 20, 2024 14:56
@pgunapal
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=f91b8bac-95f6-4859-9c97-6236d67bfdf4

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 6 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_ps63MKtgEe-5Tq7vYMk6IA

Target locations of links might be accessible only to IBM employees.

@pgunapal
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1f61333d-3942-461e-9fe2-2227d091b0a4

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 6 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=1f61333d-3942-461e-9fe2-2227d091b0a4 has errors/failures.

@websterc87
Copy link
Member

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=be184014-d926-4be5-bdac-a90c620f0783

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 6 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=f91b8bac-95f6-4859-9c97-6236d67bfdf4 has errors/failures.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_CDEB8KwtEe-5Tq7vYMk6IA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_oJm_kKxLEe-5Tq7vYMk6IA

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=be184014-d926-4be5-bdac-a90c620f0783 has errors/failures.

@pgunapal pgunapal requested a review from fmhwong November 28, 2024 14:22
@pgunapal
Copy link
Member Author

RTC build passed: https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_oJm_kKxLEe-5Tq7vYMk6IA&tab=com.ibm.team.build.web.ui.internal.editors.result.test.TestProvider

fmhwong
fmhwong reviewed Nov 28, 2024
View reviewed changes
...src/io/openliberty/microprofile/telemetry20/logging/internal/MpTelemetryLogMappingUtils.java
* Maps the Audit log events to the OpenTelemetry Logs Data Model.
*
* @param builder The OpenTelemetry LogRecordBuilder, which is used to construct the LogRecord.
* @param eventType The object originating from logging source which contains necessary fields.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of eventType and event do not match.

fmhwong
fmhwong approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@fmhwong fmhwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

@pgunapal
Copy link
Member Author

pgunapal commented Nov 28, 2024 •
edited by LibbyBot
Loading

#build (view Open Liberty Personal Build - ❌ completed with errors/failures.)

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 6 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

  • 5 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lqec0K3OEe-5Tq7vYMk6IA

Target locations of links might be accessible only to IBM employees.

@pgunapal pgunapal merged commit e494ee2 into OpenLiberty:integration Dec 5, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmhwong fmhwong fmhwong approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgunapal @LibbyBot @websterc87 @fmhwong