Skip to content

Commit 406cff2

Browse files
authored
Merge pull request #65 from peternewman/master
Add the conf page build config
2 parents cb6155e + 50ee8a1 commit 406cff2

File tree

4 files changed

+39
-5
lines changed

4 files changed

+39
-5
lines changed

.travis-ci.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ if [[ $TASK = 'flake8' ]]; then
88
# build.config has to be checked seperately, as it's not strictly a Python file
99
flake8 --max-line-length 80 --exclude *_pb2.py,.git,__pycache --ignore E111,E121,E129,F821 build.config
1010
elif [[ $TASK = 'pychecker' ]]; then
11-
# Can't check these files as they aren't true .py files: build.config master.cfg
12-
pychecker --quiet --maxargs 12 config_helper.py pass_toucher.py
11+
# Can't check these files as they aren't true .py files: build.config master.cfg
12+
pychecker --quiet --maxargs 13 config_helper.py pass_toucher.py
1313
else
1414
# Otherwise run checkconfig as normal
1515
mkdir buildbot && cd buildbot && buildbot create-master master && \

build.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ SLAVES = {
7373
ja_rule_slave=True, has_ola_ja_rule_deps=False), # Peter
7474
],
7575
'i686': [
76-
Slave('docs', generate_doc=True, generate_man=True,
76+
Slave('docs', generate_conf=True, generate_doc=True, generate_man=True,
7777
no_build=True, ja_rule_slave=True), # Simon, GCE VM
7878
Slave('noopenslp'), # RenZO
7979
],

config_helper.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,15 @@ def LoadConfig(config_file):
3030
class SlaveConfig(object):
3131
def __init__(self, suffix, has_cpp_lint=False, has_js_lint=False,
3232
has_tcmalloc=False, has_ola_ja_rule_deps=True, is_slow=False,
33-
generate_doc=False, generate_man=False, no_build=False,
34-
ola_slave=True, ja_rule_slave=False):
33+
generate_conf=False, generate_doc=False, generate_man=False,
34+
no_build=False, ola_slave=True, ja_rule_slave=False):
3535
self._suffix = suffix
3636
self._has_cpp_lint = has_cpp_lint
3737
self._has_js_lint = has_js_lint
3838
self._has_tcmalloc = has_tcmalloc
3939
self._has_ola_ja_rule_deps = has_ola_ja_rule_deps
4040
self._is_slow = is_slow
41+
self._generate_conf = generate_conf
4142
self._generate_doc = generate_doc
4243
self._generate_man = generate_man
4344
self._no_build = no_build
@@ -68,6 +69,10 @@ def has_ola_ja_rule_deps(self):
6869
def is_slow(self):
6970
return self._is_slow
7071

72+
@property
73+
def generate_conf(self):
74+
return self._generate_conf
75+
7176
@property
7277
def generate_doc(self):
7378
return self._generate_doc
@@ -99,6 +104,7 @@ def __init__(self, platform, arch, slave_config):
99104
self._has_tcmalloc = slave_config.has_tcmalloc
100105
self._has_ola_ja_rule_deps = slave_config.has_ola_ja_rule_deps
101106
self._is_slow = slave_config.is_slow
107+
self._generate_conf = slave_config.generate_conf
102108
self._generate_doc = slave_config.generate_doc
103109
self._generate_man = slave_config.generate_man
104110
self._no_build = slave_config.no_build
@@ -138,6 +144,10 @@ def has_ola_ja_rule_deps(self):
138144
def is_slow(self):
139145
return self._is_slow
140146

147+
@property
148+
def generate_conf(self):
149+
return self._generate_conf
150+
141151
@property
142152
def generate_doc(self):
143153
return self._generate_doc
@@ -184,6 +194,11 @@ def IsSlow(slave):
184194
return slave.is_slow
185195

186196

197+
def GenerateConf(slave):
198+
"""Filter on slaves that generate conf pages."""
199+
return slave.generate_conf
200+
201+
187202
def GenerateDoc(slave):
188203
"""Filter on slaves that generate doxygen doc."""
189204
return slave.generate_doc

master.cfg

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,14 @@ ola_hc_factory.addStep(Compile(
208208
lazylogfiles=True,
209209
))
210210

211+
# OLA conf help factory
212+
ola_conf_factory = BuildFactory()
213+
ola_conf_factory.addStep(Git(repourl=BuildRepoURL(config['OLA_REPO'])))
214+
ola_conf_factory.addStep(ShellCommand(
215+
workdir="build/plugins",
216+
command=["./generate-html.sh", "/opt/www/docs.openlighting.org/ola/conf/"],
217+
name="generate"))
218+
211219
# OLA doxygen doc factory
212220
ola_doc_factory = BuildFactory()
213221
ola_doc_factory.addStep(Git(repourl=BuildRepoURL(config['OLA_REPO'])))
@@ -372,6 +380,17 @@ for branch_name in builder_branches['ola'].keys():
372380

373381
# Trunk only builders, these generally generate output to the website, so we
374382
# only run them against the bleeding edge trunk branch
383+
ola_conf_slaves = slaves.GetSlaves(config_helper.OlaSlave,
384+
config_helper.GenerateConf)
385+
if ola_conf_slaves:
386+
builder_branches['ola'][config['OLA_TRUNK_NAME']].append(
387+
"conf-page-generator-ola")
388+
c['builders'].append(
389+
BuilderConfig(name="conf-page-generator-ola",
390+
slavenames=[s.name() for s in ola_conf_slaves],
391+
factory=ola_conf_factory,
392+
tags=['ola', ("ola-%s" % config['OLA_TRUNK_NAME'])]))
393+
375394
ola_doc_slaves = slaves.GetSlaves(config_helper.OlaSlave,
376395
config_helper.GenerateDoc)
377396
if ola_doc_slaves:

0 commit comments

Comments
 (0)