Adjust tqdm logging in dbt-ol. #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:ci
JDarDagran
force-pushed
the
dbt/adjust-tqdm-logging
branch
from
4419214 to
7fe21f0
Compare
mobuchowski
approved these changes
Feb 1, 2023
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Fix ruff issues in gcs extractor. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Run integration-common unit tests when modyfing integration-dbt. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
dbt/adjust-tqdm-logging
branch
from
7fe21f0 to
7d5f023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakub Dardzinski kuba0221@gmail.com
Fix ruff issues in gcs extractor.
Signed-off-by: Jakub Dardzinski kuba0221@gmail.com
Run integration-common unit tests when modyfing integration-dbt.
Signed-off-by: Jakub Dardzinski kuba0221@gmail.com
Problem
dbt-ollogged wrong number of events emitted withtqdm. Also it did not emit START event for parent run.Closes: #1481
Solution
Emit start event. Adjust
tqdmto show correct number of iterations.Checklist
CHANGELOG.mdwith details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project