-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLIENT][JAVA] Added a loadOpenLineageJson(InputStream) method, and refactored the existing loadOpenLineageYaml(InputStream) method #2490
Conversation
6b63f0c
to
66cfa7c
Compare
d37d429
to
7c7cae4
Compare
ba056a5
to
3e3ecfa
Compare
…oadOpenLineageYaml(InputStream) method This was done in an effort to be explicit about what the method requires Also added (auto-generated) JavaDocs Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com>
Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com>
Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com>
3e3ecfa
to
bc35bbc
Compare
@d-m-h @pawel-big-lebowski do you think we can actually change name of |
@mobuchowski I think we can go for that. I cannot guarantee this will not cause issue for custom java client users, but this should have a moderate impact on Spark & Flink integration. @d-m-h I really like the idea of fallback to JSON config if the yaml parsing fails 🥇 |
Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com>
Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com>
I initially wanted to do that, but I decided on the split method approach and then the subsequent fallback approach, because I could not measure the impact. |
…efactored the existing loadOpenLineageYaml(InputStream) method (OpenLineage#2490) * Added a loadOpenLineageJson(InputStream) method, and refactored the loadOpenLineageYaml(InputStream) method * Improved the error handling for loadOpenLineageYaml(ConfigPathProvider) * Explicitly state the exceptions, despite being unchecked exceptions Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com> Signed-off-by: Ruihua Wang <ruihuawang@microsoft.com>
…efactored the existing loadOpenLineageYaml(InputStream) method (OpenLineage#2490) * Added a loadOpenLineageJson(InputStream) method, and refactored the loadOpenLineageYaml(InputStream) method * Improved the error handling for loadOpenLineageYaml(ConfigPathProvider) * Explicitly state the exceptions, despite being unchecked exceptions Signed-off-by: Damien Hawes <d-m-h@users.noreply.github.com> Signed-off-by: Fabio Manganiello <fabio@manganiello.tech>
Problem
The
loadOpenLineageYaml(InputStream)
method asked for YAML (via the method name), but it actually expected JSON via the method implementation.Closes: #2487
Solution
loadOpenLineageJson(InputStream)
that expects and utilises JSON.Checklist
SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project