Support Spark 4.0 #2854
Merged
Support Spark 4.0 #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:ci
pawel-big-lebowski
force-pushed
the
spark/support-spark-4.0
branch
from
baf30ec to
88915a1
Compare
pawel-big-lebowski
force-pushed
the
spark/support-spark-4.0
branch
10 times, most recently
from
1456811 to
e660c65
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2854 +/- ##
=======================================
Coverage 85.52% 85.52%
=======================================
Files 58 58
Lines 3413 3413
=======================================
Hits 2919 2919
Misses 494 494 ☔ View full report in Codecov by Sentry. |
pawel-big-lebowski
force-pushed
the
spark/support-spark-4.0
branch
from
e660c65 to
612487c
Compare
pawel-big-lebowski
force-pushed
the
spark/support-spark-4.0
branch
10 times, most recently
from
91aba83 to
42f9e67
Compare
pawel-big-lebowski
force-pushed
the
spark/support-spark-4.0
branch
2 times, most recently
from
bc29477 to
7f75063
Compare
mobuchowski
reviewed
Jul 31, 2024
integration/spark/app/src/main/java/io/openlineage/spark/agent/OpenLineageSparkListener.java
Outdated
Show resolved
Hide resolved
| private static final String SPARK_3 = "(3.*)"; | ||
| private static final String SPARK_3_3 = "(3\\.[3-9].*)"; | ||
| private static final String GREATER_THAN_SPARK2 = "(3.*)"; | ||
| private static final String GREATER_THAN_SPARK3_3 = "(3\\.[3-9].*)"; |
There was a problem hiding this comment.
Should those both contain Spark 4? If not, why?
There was a problem hiding this comment.
As mentioned few lines above:
// TODO: Please note the test remains disabled for Spark 4.0 for now (no applicable connector
// version available)
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
pawel-big-lebowski
force-pushed
the
spark/support-spark-4.0
branch
from
7f75063 to
2c970a5
Compare
mobuchowski
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Spark 4.0 preview -> https://spark.apache.org/news/spark-4.0.0-preview1.html