From 8957084d1c75ac903ea048cdc2f91ebb2c87d13d Mon Sep 17 00:00:00 2001 From: "matt.d" Date: Thu, 3 Aug 2023 14:56:02 -0700 Subject: [PATCH 1/2] use correct var names for group_vars --- group_vars/onyx.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/group_vars/onyx.yml b/group_vars/onyx.yml index 76c4491..f8cb6e0 100644 --- a/group_vars/onyx.yml +++ b/group_vars/onyx.yml @@ -2,6 +2,5 @@ ansible_connection: network_cli ansible_network_os: onyx -gather_facts: false -become: true -become_method: enable +ansible_become: true +ansible_become_method: enable From e18e45ff4d5ac4b9345a1447036b2006cf8036f9 Mon Sep 17 00:00:00 2001 From: "matt.d" Date: Thu, 3 Aug 2023 14:56:26 -0700 Subject: [PATCH 2/2] remove unnecessary onyx overrides from plays --- playbooks/configure_vlans.yml | 10 ---------- playbooks/remove_vlans.yml | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/playbooks/configure_vlans.yml b/playbooks/configure_vlans.yml index c8f81f9..a3e281d 100644 --- a/playbooks/configure_vlans.yml +++ b/playbooks/configure_vlans.yml @@ -83,12 +83,7 @@ - name: Get Onyx LLDP tables hosts: onyx - connection: network_cli gather_facts: false - become: true - become_method: enable - vars: - ansible_network_os: onyx roles: - get_onyx_lldp @@ -104,11 +99,6 @@ - name: Configure Onyx VLANs hosts: onyx - connection: network_cli gather_facts: false - become: true - become_method: enable - vars: - ansible_network_os: onyx roles: - configure_onyx_vlans diff --git a/playbooks/remove_vlans.yml b/playbooks/remove_vlans.yml index ad21cb3..ffaf591 100644 --- a/playbooks/remove_vlans.yml +++ b/playbooks/remove_vlans.yml @@ -47,12 +47,7 @@ - name: Get Onyx LLDP tables hosts: onyx - connection: network_cli gather_facts: false - become: true - become_method: enable - vars: - ansible_network_os: onyx roles: - get_onyx_lldp @@ -67,11 +62,6 @@ - name: Remove Onyx allowed VLANs hosts: onyx - connection: network_cli gather_facts: false - become: true - become_method: enable - vars: - ansible_network_os: onyx roles: - remove_onyx_allowed_vlans