Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of Terms and Conditions #1288

Closed
addison74 opened this issue Oct 28, 2020 · 3 comments · Fixed by #1480
Closed

Change order of Terms and Conditions #1288

addison74 opened this issue Oct 28, 2020 · 3 comments · Fixed by #1480

Comments

@addison74
Copy link
Contributor

addison74 commented Oct 28, 2020

This is a known issue in Magento. There is no option to change the order of your Terms and Conditions (Backend -> Sales -> Terms and conditions). BTW it should be a capital letter "C" there in the link name, and in other places too (e.g. Reports menu).

The only way to change the order is by editing the database. In 2017 I reported this issue on magento.stackexchange.com and sreichel who is a nice gentleman and supportive person solve it here: https://github.com/sreichel/magento-Sr-AgreementPosition.

I vote for adding this missing feature to OpenMage.

@addison74 addison74 changed the title Change order of Terms and Conditions - Missing feature Change order of Terms and Conditions Oct 28, 2020
@sreichel
Copy link
Contributor

sreichel commented Mar 2, 2021

I would make a PR later ... Do you still need the option for content to be optional? Should it be part of the PR?

@addison74
Copy link
Contributor Author

I am using your work with stores in Europe having even 4 checkboxes. It would be great to integrate this missing feature in OpenMage.

Content shouldn't be a required field. I analyzed most of the situations and I found that we shouldn't ask for filling it up. For example, in the stores I mentioned there are only checkboxes with text labels but no content. If this field was required I was not able to save the form.

Do you think we need such of options for Checkbox Text and Content fields?

Screenshot 2021-03-02 172608

@sreichel
Copy link
Contributor

sreichel commented Mar 2, 2021

Do you think we need such of options for Checkbox Text and Content fields?

No. And I'm not going to add TinyMCE anywhere ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants