Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong attributes order in comparison window #1289

Closed
addison74 opened this issue Oct 28, 2020 · 3 comments
Closed

Wrong attributes order in comparison window #1289

addison74 opened this issue Oct 28, 2020 · 3 comments
Labels
Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav new feature

Comments

@addison74
Copy link
Contributor

This is a known issue in Magento. The attributes order listed in product page is not the same in comparison window. In the past I reported this issue on Stack Exchange and Magento Forum. Here are the links:

https://magento.stackexchange.com/questions/64983/attributes-order-in-comparison-window-is-wrong

https://community.magento.com/t5/Can-Magento-do/Attributes-order-in-comparison-window-is-wrong/m-p/4137

I vote for adding this missing feature to OpenMage.
@kiatng kiatng added Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav labels Oct 29, 2020
@seansan
Copy link
Contributor

seansan commented Oct 30, 2020

Wow! Thats a very old issue 2015 ... good one

btw is the "old" bugs database/reporting system from M1 still exist somewhere?

@addison74
Copy link
Contributor Author

Between 2014 - 2018 I reported a lot of issues in Magento 1 Bugtracker. Some of them were took in consideration. Unfortunately I don't think there is a backup to it.

@addison74 addison74 mentioned this issue Nov 25, 2020
Merged
3 tasks
@addison74
Copy link
Contributor Author

I will close this issue. Please check #1568 for a fix.

@addison74 addison74 mentioned this issue Apr 23, 2021
Merged
Flyingmana added a commit that referenced this issue May 16, 2021
@Flyingmana
Fixes for #1564 and #1289 (#1568)
ec729b2 
* Update agreements.phtml

By PR #1480 which is merged in OM the content field is no longer required. If it is not filled in an empty container will be visible in frontend. This PR comes to solve this issue.

* Uppercase format in Sales menu - Terms and conditions

This commit will change in Backend -> Sales menu a link name from "Terms and conditions" to "Terms and Conditions". 

It is not necessary to add the text in /app/locale/en_US/Mage_Checkout.csv because it already exists. I chose to keep the old version too.

* Wrong attributes order in comparison window

This PR fixes the issue #1289.

* Update Collection.php

Co-authored-by: Daniel Fahlke <flyingmana@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog Component: Eav Relates to Mage_Eav new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seansan @kiatng @addison74