Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout - Agreement content when empty (Terms and Conditions) #1564

Closed
addison74 opened this issue Apr 21, 2021 · 1 comment · Fixed by #1568
Closed

Checkout - Agreement content when empty (Terms and Conditions) #1564

addison74 opened this issue Apr 21, 2021 · 1 comment · Fixed by #1568
Labels
bug

Comments

@addison74
Copy link
Contributor

addison74 commented Apr 21, 2021 •
edited
Loading

With #1480 the Content field is no longer required which is a normal behavior. This field is not always used.

agreement_2

A strange behavior occurs in frontend if I don't fill in the textarea.

agreement_1

As you can see although I did not enter a content for the first term I get an empty div.

This template /frontend/base/default/template/checkout/onepage/agreements.phtml was not intended for such a situation so it should be changed. If there is no value for Content then do not display that div.

I would make another change in the Sales menu. "Terms and conditions" should become "Terms and Conditions" to keep the same uppercase format like for other links.

If I have some time I will create this commit.
@addison74 addison74 added the bug label Apr 21, 2021
@addison74 addison74 mentioned this issue Apr 23, 2021
Merged
@addison74
Copy link
Contributor Author

I will close this issue. Please check #1568 for a fix.

Flyingmana added a commit that referenced this issue May 16, 2021
@Flyingmana
Fixes for #1564 and #1289 (#1568)
ec729b2 
* Update agreements.phtml

By PR #1480 which is merged in OM the content field is no longer required. If it is not filled in an empty container will be visible in frontend. This PR comes to solve this issue.

* Uppercase format in Sales menu - Terms and conditions

This commit will change in Backend -> Sales menu a link name from "Terms and conditions" to "Terms and Conditions". 

It is not necessary to add the text in /app/locale/en_US/Mage_Checkout.csv because it already exists. I chose to keep the old version too.

* Wrong attributes order in comparison window

This PR fixes the issue #1289.

* Update Collection.php

Co-authored-by: Daniel Fahlke <flyingmana@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for #1564 and #1289
1 participant
@addison74