Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Magento Notifications #683

Closed
kkrieger85 opened this issue May 29, 2019 · 10 comments
Closed

Replace Magento Notifications #683

kkrieger85 opened this issue May 29, 2019 · 10 comments
Assignees
Labels
Cleanup Component: AdminNotification Relates to Mage_AdminNotification enhancement rebranding Change Magento to OpenMage LTS

Comments

@kkrieger85
Copy link
Contributor

<feed_url>notifications.magentocommerce.com/community/notifications.rss</feed_url>

@kkrieger85
Copy link
Contributor Author

Proposal: Create own notification rss in https://github.com/OpenMage/OpenMage.github.io to inform user.

Alternative: Remove AdminNotification at all

@spinsch
Copy link
Contributor

spinsch commented May 29, 2019

After adobe has bought magento, the notifications feel like shitty newsletters with useless information about migration service for magento 2.

I'm also happy if we change something on the notification system.

Now i've disabled the notification rss update via local.xml on my production instance:

<adminhtml>
    <events>
        <controller_action_predispatch>
            <observers>
                <adminnotification>
                    <type>disabled</type>
                </adminnotification>
            </observers>
        </controller_action_predispatch>
    </events>
</adminhtml>

@Flyingmana
Copy link
Contributor

doing it as part of the website sounds ok, but would do it in a separate repository to have a better access-controll and more strict rules.
Reason is, this would be a message to all stores, so we need to make the process of adding something as robust, as a contribution to the core code itself.

Another point is, would we want to use this for tracking installs?
It would be an opportunity for this and have more useful numbers then the downloads.

Doing it via github pages would prevent this for now, as we do not have access to the access.log, so this would be good if we definitely do not want to track it over this.

@kkrieger85
Copy link
Contributor Author

doing it as part of the website sounds ok, but would do it in a separate repository to have a better access-controll and more strict rules.

👍

Reason is, this would be a message to all stores, so we need to make the process of adding something as robust, as a contribution to the core code itself.

👍

Another point is, would we want to use this for tracking installs?
It would be an opportunity for this and have more useful numbers then the downloads.

If so, we should offer an opt-out

@Flyingmana
Copy link
Contributor

I started the Repository https://github.com/OpenMage/Web_Notifications
which currently is available via https://openmage.github.io/Web_Notifications/index

Will need to look in which format we need to provide the Feed, to prepare the template accordingly.

@spinsch
Copy link
Contributor

spinsch commented Apr 17, 2020

Just noticed in my test environment that the feed URL triggers a 301 redirect and throws an error in my magento system.log

https://openmage.github.io/Web_Notifications/notifications_v1.rss
goes to
http://www.openmage.org/Web_Notifications/notifications_v1.rss

@Flyingmana
Copy link
Contributor

indeed, reason is probably OpenMage/OpenMage.github.io@fea9d0f from @LeeSaferite

i guess we should either update the url, or allow following redirects(is this possible?)

@sreichel sreichel added rebranding Change Magento to OpenMage LTS Component: AdminNotification Relates to Mage_AdminNotification labels Jun 13, 2020
@fballiano
Copy link
Contributor

Is the notification really needed? I've always felt (with all the stores I've worked on) that it was just "in the way" and nobody ever paid attention to those notifications. Most of the stuff is handled by developers/consultants which almost never use the backend...

Same goes for both adobe's notification and 3rd party modules notifications.

In my opinion it would be better to disable/remove the feature.

@kkrieger85
Copy link
Contributor Author

Partly done in #994

@fballiano
Copy link
Contributor

This was managed, although not completely, in #994 so, since we've no update since 1.5years, I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: AdminNotification Relates to Mage_AdminNotification enhancement rebranding Change Magento to OpenMage LTS
Projects
None yet
Development

No branches or pull requests

5 participants