Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Around Version Numbers #985

Closed
cdbessig opened this issue May 18, 2020 · 3 comments · Fixed by #1160
Closed

Documentation Around Version Numbers #985

cdbessig opened this issue May 18, 2020 · 3 comments · Fixed by #1160
Assignees

Comments

@cdbessig
Copy link

I believe some clarity around this would be good. For example, I read that 19.4.1 should be used as per here.

However, when I place that on top of my magento code (just a zip file download and a copy over), in the admin panel I get Magento ver. 1.9.4.4.

If I go to the github repo and just do git clone https://github.com/OpenMage/magento-lts.git then copy the files over I get Magento ver. 1.9.4.5

I never see anything like 19.4.1. Worse off, when I git clone https://github.com/OpenMage/magento-lts.git I got commits from today. I was under the assumption that a LTS version should have released versions and not just pull in all of the latest commits.

My recommendations here are as follows:

  • Establish true documentation on how to upgrade / version numbers / etc.
  • Add an OpenMage LTS version number in the footer of admin above or below current magento version. (Or replace completely, if allowed by liscense)

Maybe I am just confused, or perhaps this will confuse others as well.

Thanks!

@fitzjohnit
Copy link
Contributor

Hi,

Yes I think it needs updating as didn't work for me either. Using "19.4.x" (which took from the further instructions link) did and I'm now on version 1.9.4.5 from Magento's point of view. I've created a pull request #992 to amend the README.md which hopefully is correct and will get accepted if so.

Thanks,

Ed

@fballiano
Copy link
Contributor

Agree, there's the need for a more clear documentation about the versioning.

@sreichel sreichel self-assigned this Aug 22, 2020
@sreichel
Copy link
Contributor

My recommendations here are as follows:

  • Establish true documentation on how to upgrade / version numbers / etc.
  • Add an OpenMage LTS version number in the footer of admin above or below current magento version. (Or replace completely, if allowed by liscense)

1st

  • current instruction for composer install is wrong and need to be fixed
  • install instructions at openmage.org was not up to date (didnt match current release) - is fixed

2nd

Actually working on this ...

Flyingmana pushed a commit that referenced this issue Feb 13, 2021
* Updated README.md, closes #992

- add branch alias to composer.json (see #992#issuecomment-638974892)
- add AFL 3.0 license
- removed duplicate LICENSE.html
- ...

* Renamed dev-master to dev-main

* Renamed dev-master to dev-main - missed one

* Added event #1168

Co-authored-by: Sven Reichel <sven.reichel@sandstein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants