-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README.md, closes #985 #992 #1160
Conversation
- add branch alias to composer.json (see #992#issuecomment-638974892) - add AFL 3.0 license - removed duplicate LICENSE.html - ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use something else than "dev-master"
Master is a deprecated term/phrase. Following githubs naming here, "dev-main" would be an appropriate alternative.
Looks good! No objections. On the section for "If you want to contribute to the project:" what about mentioning the one-step dev environment by either adding a link to the README or adding the command to the list of shell commands given?
|
@colinmollenhour Absolutely, but I'd like to leave that up to you. I would prefer the link to a README, this one you can manage yourself without needing PRs here. |
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Questions or comments
Contribution checklist (*)