Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1095 remove notification survey block #1267

Merged
merged 5 commits into from
May 2, 2022
Merged

1095 remove notification survey block #1267

merged 5 commits into from
May 2, 2022

Conversation

kkrieger85
Copy link
Contributor

Remove block in adminhtml template:
<type="adminhtml/notification_survey" name="notification_survey" template="notification/survey.phtml"/>
Remove survey related code
Remove survey related translation

After merging, in adminhtml should be no more survey block

no_survey

closes #1095

@kkrieger85 kkrieger85 added hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted Component: AdminNotification Relates to Mage_AdminNotification Component: Adminhtml Relates to Mage_Adminhtml labels Oct 18, 2020
@kkrieger85 kkrieger85 changed the base branch from 20.0 to 1.9.4.x October 18, 2020 16:02
@github-actions github-actions bot added Component: Install Relates to Mage_Install composer Relates to composer.json Template : admin Relates to admin template translations Relates to app/locale labels Oct 18, 2020
This was referenced Oct 18, 2020
Closed
Closed
@luigifab
Copy link
Contributor

Without composer.json and captainhook.json, it's ready? and #1268 can be closed?

@kkrieger85
Copy link
Contributor Author

#1268 has v20 as target branch.

Will update both PR

@github-actions github-actions bot removed the composer Relates to composer.json label Feb 18, 2022
kkrieger (Kevin Krieger) added 5 commits February 18, 2022 19:07
@kkrieger85
Copy link
Contributor Author

@luigifab Files removed, merge conflict solved

kiatng
kiatng approved these changes Feb 19, 2022
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, the entry admin_notification_survey in table core_flag will become a ghost when updating existing OM.

@fballiano fballiano merged commit 4c8cac3 into OpenMage:1.9.4.x May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 4c8cac3. ± Comparison against base commit a1b01fa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigifab luigifab luigifab approved these changes

@Sekiphp Sekiphp Sekiphp approved these changes

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Install Relates to Mage_Install hacktoberfest easy to solve issues for https://hacktoberfest.digitalocean.com/ participant (and everyone else) hacktoberfest-accepted Template : admin Relates to admin template translations Relates to app/locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup: Remove Mage_Adminhtml_Block_Notification_Survey
5 participants
@kkrieger85 @luigifab @fballiano @kiatng @Sekiphp