Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed return type of Mage_Adminhtml_Block_System_Config_Form::_canShowField #1356

Merged
merged 1 commit into from
Dec 31, 2020
Merged

Conversation

midlan
Copy link
Contributor

@midlan midlan commented Dec 15, 2020

Description (*)

It should return bool. So fixed the (int) to (bool)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@midlan midlan changed the title Fixed return type of \Mage_Adminhtml_Block_System_Config_Form::_canShowField Fixed return type of Mage_Adminhtml_Block_System_Config_Form::_canShowField Dec 15, 2020
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Dec 15, 2020
@tmotyl tmotyl merged commit c202af9 into OpenMage:1.9.4.x Dec 31, 2020
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit c202af9.

@midlan midlan deleted the patch-2 branch December 31, 2020 10:31
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants