Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplified true/false #1398

Merged
merged 7 commits into from
Mar 12, 2021
Merged

Simplified true/false #1398

merged 7 commits into from
Mar 12, 2021

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 14, 2021 •
edited
Loading

Description (*)

Removed unnecessary true/false

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the Cleanup: Code style Related to simple CS fixes. label Jan 14, 2021
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Bundle Relates to Mage_Bundle Component: Centinel Relates to Mage_Centinel Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales labels Jan 14, 2021
kiatng
kiatng requested changes Mar 11, 2021
View reviewed changes
app/code/core/Mage/Core/Model/Config.php Outdated Show resolved Hide resolved
app/code/core/Mage/Admin/Model/User.php Outdated Show resolved Hide resolved
app/code/core/Mage/Api/Model/User.php Outdated Show resolved Hide resolved
app/code/core/Mage/Api/Model/User.php Outdated Show resolved Hide resolved
sreichel and others added 6 commits March 12, 2021 00:26
@sreichel @kiatng
Update app/code/core/Mage/Api/Model/User.php
c431241 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Api/Model/User.php
0e978ea 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Admin/Model/User.php
c65762f 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Core/Model/Config.php
2b41d57 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Admin/Model/User.php
39c50ec 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Adminhtml/Block/Catalog/Category/Tree.php
1d75610 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
kiatng
kiatng approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@sreichel sreichel merged commit 6f2c8ee into OpenMage:1.9.4.x Mar 12, 2021
@sreichel sreichel deleted the cs/simple-expr branch March 12, 2021 18:14
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6f2c8ee. ± Comparison against base commit 5ddb7a3.

@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes. Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Bundle Relates to Mage_Bundle Component: Centinel Relates to Mage_Centinel Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales
Projects
None yet
Milestone
Release 19.4.12 / 20.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @colinmollenhour @kiatng @kkrieger85