Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced multiple dispatch events in login form for other themes. #1407

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Reduced multiple dispatch events in login form for other themes. #1407

merged 1 commit into from
Feb 13, 2021

Conversation

AlterWeb
Copy link
Contributor

@AlterWeb AlterWeb commented Jan 20, 2021 •
edited by sreichel
Loading

Description (*)

Reduced multiple dispatch events in login form for other themes. After pull request #1206.

Related Pull Requests

#1206

Manual testing scenarios (*)

  1. Not applicable.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Persistant Relates to Mage_Persistant Template : base Relates to base template Template : default Relates to base template labels Jan 20, 2021
@AlterWeb AlterWeb mentioned this pull request Jan 20, 2021
Merged
3 tasks
kiatng
kiatng approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up.

@sreichel sreichel requested review from kkrieger85 and tmotyl February 1, 2021 23:49
@Flyingmana Flyingmana merged commit 2bdd36a into OpenMage:1.9.4.x Feb 13, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2bdd36a. ± Comparison against base commit bbd05be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@kiatng kiatng kiatng approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@kkrieger85 kkrieger85 Awaiting requested review from kkrieger85

@tmotyl tmotyl Awaiting requested review from tmotyl

Assignees
No one assigned
Labels
Component: Persistant Relates to Mage_Persistant Template : base Relates to base template Template : default Relates to base template
Projects
None yet
Milestone
Release 19.4.11 / 20.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@AlterWeb @Flyingmana @kiatng @sreichel