Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page title for credit memo and shipment #1416

Merged
merged 1 commit into from
May 23, 2021
Merged

Page title for credit memo and shipment #1416

merged 1 commit into from
May 23, 2021

Conversation

luigifab
Copy link
Contributor

Description

This useless PR set title for two pages:

  • #100000004 / Invoices / Sales / OpenMage Admin (no change)
  • View Memo / Credit Memos / Sales / OpenMage Admin => #100000003 / Credit Memos / Sales / OpenMage Admin
  • View Shipment / Shipments / Sales / OpenMage Admin => #100000004 / Shipments / Sales / OpenMage Admin

OpenMage 20.0.6 / PHP 8.0.1

Manual testing scenarios

Go to Sales / Order, open an order, create an invoice, a shipment, a credit memo, and open them in a new tab.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml translations Relates to app/locale labels Jan 22, 2021
@Flyingmana Flyingmana merged commit 76e8fe3 into OpenMage:1.9.4.x May 23, 2021
@luigifab luigifab deleted the page-title branch May 23, 2021 17:34
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  2 💤 +2  0 ❌ ±0 

Results for commit 76e8fe3. ± Comparison against base commit bbd05be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml enhancement translations Relates to app/locale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants