Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integrity constraint violation when order is canceled #1473

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix integrity constraint violation when order is canceled #1473

merged 1 commit into from
Feb 25, 2021

Conversation

luigifab
Copy link
Contributor

Description

This PR fix #1220 and #1472.

OpenMage 19.4.10 / 20.0.3 / 20.0.5 / 20.0.7
PHP 7.2.31 / 7.4.6

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: SalesRule Relates to Mage_SalesRule label Feb 23, 2021
colinmollenhour
colinmollenhour approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, this should have been obvious..

@sreichel sreichel merged commit 7f185e5 into OpenMage:1.9.4.x Feb 25, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Feb 25, 2021
@sreichel sreichel added the bug label Feb 25, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7f185e5. ± Comparison against base commit 741222f.

@luigifab luigifab deleted the fix-integrity-cancel branch April 15, 2021 10:05
@gkopec gkopec mentioned this pull request Apr 30, 2021
Closed
@luigifab luigifab restored the fix-integrity-cancel branch June 6, 2021 11:15
@luigifab luigifab deleted the fix-integrity-cancel branch June 6, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@jfksk jfksk jfksk approved these changes

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
bug Component: SalesRule Relates to Mage_SalesRule
Projects
None yet
Milestone
Release 19.4.12 / 20.0.8
Development

Successfully merging this pull request may close these issues.

Observer sales_order_paymentCancel and integrity constraint violation
5 participants
@luigifab @colinmollenhour @kiatng @jfksk @sreichel