Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an Exception in resource model if column not exists, instead of E_NOTICE #1531

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Throw an Exception in resource model if column not exists, instead of E_NOTICE #1531

merged 2 commits into from
Apr 14, 2021

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Apr 7, 2021 •
edited
Loading

Description / Manual testing scenarios

Consider following code:

Mage::getModel('catalog/product')->load('value', 'unexisting_column');

Now is show following error:
113858340-e6a57a80-97a3-11eb-88ac-f77031d4842d

After change is thrown Exception with info, which column does not exist.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Apr 7, 2021
@Sekiphp @kiatng
Update app/code/core/Mage/Core/Model/Resource/Db/Abstract.php
3b570e2 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@midlan midlan changed the title Throwing Exception when column not exists instead of E_NOTICE Throwing Exception when column not exists Apr 13, 2021
@midlan midlan changed the title Throwing Exception when column not exists Throwing Exception when column not exists in resource model Apr 13, 2021
@Sekiphp Sekiphp merged commit d44a8dd into OpenMage:1.9.4.x Apr 14, 2021
@Sekiphp Sekiphp deleted the feature/getLoadSelect-unexisting-key branch April 14, 2021 10:55
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d44a8dd. ± Comparison against base commit 242a99b.

@Flyingmana Flyingmana changed the title Throwing Exception when column not exists in resource model Throw an Exception in resource model if column not exists, instead of E_NOTICE Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midlan midlan midlan approved these changes

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sekiphp @colinmollenhour @fballiano @kiatng @midlan