Removed orphan directory and code of compiler and downloder.

[kiatng]

Description (*)

Related Pull Requests

PR #534 and PR #952.

Fixed Issues (if relevant)

1. Fixes issue Remove orphan directory and code #1666.

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[fballiano]

I love these kinds of PRs!

[addison74]

I strongly recommend not removing /includes directory. Inside of it there is an important file named config.php that can help you to achieve some unknown features. For example, if you are using this combination HAProxy (for SSL Offloading) + Varnish + Apache in Magento Backend -> Orders page you will get a chain of IP's addresses, more precisely 3 IP's because the offloading part of Magento was never pushed to a final shape. Recently Colin Mollenhour managed to offer a correct solution for this. In order to get only one IP address listed in Orders page I am using config.php. Here is an example from production:

if(isset($_SERVER['HTTP_X_REAL_IP'])) {
    $_SERVER['REMOTE_ADDR'] = $_SERVER['HTTP_X_REAL_IP'];
    $_SERVER['HTTP_X_FORWARDED_FOR'] = '';
}

HTTP_X_REAL_IP comes from .htaccess where I am processing the IP's to get the remote one. In conclusion, config.php allows you to set many things to change what Magento gets.

[fballiano]

I strongly recommend not removing /includes directory. Inside of it there is an important file named config.php that can help you to achieve some unknown features. For example, if you are using this combination HAProxy (for SSL Offloading) + Varnish + Apache in Magento Backend -> Orders page you will get a chain of IP's addresses, more precisely 3 IP's because the offloading part of Magento was never pushed to a final shape. Recently Colin Mollenhour managed to offer a correct solution for this. In order to get only one IP address listed in Orders page I am using config.php. Here is an example from production:

if(isset($_SERVER['HTTP_X_REAL_IP'])) {
    $_SERVER['REMOTE_ADDR'] = $_SERVER['HTTP_X_REAL_IP'];
    $_SERVER['HTTP_X_FORWARDED_FOR'] = '';
}

it's interesting but in my opinion it seems the wrong place to put it (although I totally see your point). If IP chains are necessary to handle, then let's put it in the index.php. includes/config.php is 99% unused (while causing I/O) and had a totally different purpose.

[addison74]

I have nothing against as long as what I said above can be obtained in another way. Magento needs to be able to deal with such server configurations that when it was born in 2008 were not possible or accessible to anyone. I will even propose in the Discussions section on this topic.

[colinmollenhour]

I think the include for includes/config.php was already removed from index.php but it was missed from index.php.sample somehow.. Should this sample file not just be deleted as well? So already to use config.php you would have to have a modified index.php. But I agree this file is not the right place to add custom code so as a project we should consider it dead code that is safe to remove.

One minor problem with this PR is if existing installations have important files in includes directory (no idea why this would be the case) these will be potentially exposed by Apache because the .htaccess file is removed.. So maybe the .htaccess file should remain in the 1.9.4.x branch and only be removed in 20.0?

The base branch was changed.

[kiatng]

As pointed out by @addison74, this PR may break BC. I tried to edit the base branch to 20.0 but that didn't work as it brought along some 35 other commits. Not sure how to do this, do I close this PR and make a new one for branch 20?

[Flyingmana]

you can wait till next release, then all of these commits are already part of 20.0, so changing the branch will not bring them up anymore

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 10da7af. ± Comparison against base commit 3fbc99a.