Some CSS fixes to OpenMage adminhtml theme

[sreichel]

Description (*)

• made columns bit wider
• removed duplicate code from scss
• fixed wrong imports in scss
• added label for OM admin theme

Fixed Issues (if relevant)

1. Fixes New admin theme: date fields to small #2397

Manual testing scenarios (*)

1. npm install -g sass
2. ...

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[addison74]

1. It would be useful if each change was accompanied by a screenshot (for the first and last bullets in the list).

2. In the Magento theme, I solved the issue in which the date was not fully visible in the input box (PR Backend grid heads - Align the elements for range and date types #2330). Although you made the columns wider in the OpenMage theme, the issue remained. Below a comparison between themes.

3. I do not agree that the modified CSS files should be compressed. On the one hand we will get compressed files and others not in the repository and on the other hand, we affect those who were used to uncompressed files in which they made their own changes (not everyone has knowledge of SASS).

[addison74]

I tested the last version and I found that you solved the issue of the visibility of the date selected in the input box.

[addison74]

Please analyze whether a change must be made in the case below. The selection should be aligned with the others and have the same width.

[addison74]

I appreciate that the CSS files are no longer compressed and it allowed me to go through them in GitHub. You should remove "compressed output" from the PR description.

[addison74]

This comment seems to be too far from the left margin. There are a comments like this one.

[fballiano]

@addison74 do we like this as is it? :-)

[addison74]

@fballiano - I have to test it.

[sreichel]

@fballiano - I have to test it.

Just changed datefields and currency select fields. For demostore, please enable notice to test.

[addison74]

Please guide me related to these changes:

• "added label for OM admin theme"
• "For demostore, please enable notice to test"

[sreichel]

First is just a new label for github.

Somewhere in admin config you can enable "Show demostore notice".

[addison74]

I don't have a problem enabling that feature in Backend (Config > General > Design> HTML Head > Display Demo Store Notice = Yes), but let's confirm what are the changes in this PR. At the top there is the notice, the logo on the left and the two elements on the right no longer overlap. Also, if the width of the window is reduced, the elements on the right no longer overlap the menu.

This is before:

This is after:

Otherwise, they are fine the 2 changes in the grids (date ranges, currency). Also, the CSS files are no longer compressed, which allowed me to follow the changes.

[fballiano]

I'll test this as soon as I close the docblock update, cause I've 3000 modified files in my workspace at the moment :-\

[fballiano]

tested, ok

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit c691713. ± Comparison against base commit 028f783.