Addendum to #2426 - Adminhtml loader

[justinbeaty]

Description (*)

I was working on a few things and noticed I needed a few fixes for #2426.

Issues:

• Some places called Element.show('loading-mask'); directly. Because I hid the child elements, that broke the loader showing. I removed the style="display:none" from those child elements to fix it.
• In any case, I removed those direct calls and introduced a new methods to show and hide the loader from anywhere. This has the benefit of making the loader show up with a timeout in other places besides AJAX calls.
• Updated the loader html in a few other templates that I missed.

Related Pull Requests

#2426

Fixed Issues (if relevant)

Manual testing scenarios (*)

1. Test similar tasks as in Add loading delay adminhtml #2426, such as sorting an admin grid
2. Test Manage Categories page, try saving a category

Questions or comments

I apologize about the breakage, I somehow missed that the loader was displayed manually in places.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

seems much better this way

[justinbeaty]

One sec, one more change incoming.

Edit: done, I improved the logic when showLoader might be called twice in a row.

[justinbeaty]

seems much better this way

The more you look at the inline spaghetti javascript of Magento the more you want to cry 😭

[fballiano]

The more you look at the inline spaghetti javascript of Magento the more you want to cry 😭

yes ahhahaha I'm working now on an issue that's driving me crazy and it's been there since forever!

[justinbeaty]

The more you look at the inline spaghetti javascript of Magento the more you want to cry 😭

yes ahhahaha I'm working now on an issue that's driving me crazy and it's been there since forever!

Let me know if you need a second set of eyes. You can post on Discord if you want.

[fballiano]

Let me know if you need a second set of eyes. You can post on Discord if you want.

Thanks! I think I'll be able to post a PR soon (maybe today) that will need some test ehheheh

[addison74]

This is a useful PR. On the same computer in two VMs with identical allocated resources (almost top processor, memory, nvme), OM installed in Windows 10 (XAMPP) from 450 ms no longer displays the loader, Debian 10 from 25 ms no longer displays the loader. The differences are notable, if we had set a default value and it could only be changed by editing, only some would have benefited from this feature.