Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about targetNamespace change in README #2559

Merged
merged 2 commits into from
Sep 7, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ For full list of changes, you can [compare tags](https://github.com/OpenMage/mag

[Full list of events](docs/EVENTS.md)

### Changes to SOAP/WSDL

Since `19.4.17`/`20.0.15` we changed the `targetNamespace` of all the WSDL files (used in the API modules), from `Magento` to `OpenMage`.
If your custom modules extends OpenMage's APIs with a custom WSDL file and there are some hardcoded `targetNamespace="urn:Magento"` string, your APIs may stop working.
Please replace all occurrences of `targetNamespace="urn:Magento"` with `targetNamespace="urn:OpenMage"` (or alternatively `targetNamespace="urn:{{var wsdl.name}}"`) to avoid any problem.
To find which files need the modification you can run `grep -rn 'urn:Magento' --include \*.xml` from the root directory of your project.

## Development Environment with ddev

- Install [ddev](https://ddev.com/get-started/)
Expand Down