Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes for phpdocs #2588

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Some fixes for phpdocs #2588

merged 4 commits into from
Sep 12, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 11, 2022 •
edited
Loading

Description (*)

...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Sep 11, 2022
@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Eav Relates to Mage_Eav Component: Oauth Relates to Mage_Oauth Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: Reports Relates to Mage_Reports Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist labels Sep 11, 2022
@sreichel sreichel requested a review from addison74 September 12, 2022 22:06
@sreichel sreichel merged commit 71a2751 into OpenMage:1.9.4.x Sep 12, 2022
@sreichel sreichel deleted the phpdocs branch September 12, 2022 22:46
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 71a2751. ± Comparison against base commit 0e4f4a8.

@sreichel sreichel mentioned this pull request Sep 14, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng left review comments

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: Centinel Relates to Mage_Centinel Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Directory Relates to Mage_Directory Component: Eav Relates to Mage_Eav Component: Oauth Relates to Mage_Oauth Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk Component: Reports Relates to Mage_Reports Component: Rule Relates to Mage_Rule Component: Sales Relates to Mage_Sales Component: Tag Relates to Mage_Tag Component: Usa Relates to Mage_Usa Component: Wishlist Relates to Mage_Wishlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sreichel @fballiano @kiatng @addison74