Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated phpstan experimental #2589

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Updated phpstan experimental #2589

merged 1 commit into from
Sep 12, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 12, 2022 •
edited
Loading

Description (*)

See https://github.com/OpenMage/magento-lts/runs/8296112223

php_stan_experimental workflow also includes lib/* (including Zend and all others). PR changes to only inlude ...

'lib/Mage',
'lib/Magento',
'lib/Varien'

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions

This comment has been minimized.

Sign in to view
@fballiano fballiano merged commit 0e4f4a8 into 1.9.4.x Sep 12, 2022
@fballiano fballiano deleted the workflow branch September 12, 2022 07:59
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 0e4f4a8. ± Comparison against base commit d433ae9.

@sreichel
Copy link
Contributor Author

sreichel commented Sep 12, 2022 •
edited
Loading

Have to update this PR later ... committed the wrong version (with wrong syntax) :/

@sreichel sreichel mentioned this pull request Sep 12, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
environment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @kiatng