Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated github workflow #2608

Merged
merged 19 commits into from
Sep 24, 2022
Merged

Updated github workflow #2608

merged 19 commits into from
Sep 24, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 18, 2022 •
edited
Loading

Description (*)

Tried to improve github workflow ...

  • reduced number of run workflow actions from 16 to 10
  • check php8.2 syntax by default
  • updated phpstan to level 3

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel marked this pull request as draft September 18, 2022 02:33
@sreichel sreichel marked this pull request as ready for review September 18, 2022 12:00
fballiano
fballiano previously approved these changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less workflows is better

fballiano
fballiano previously approved these changes Sep 20, 2022
View reviewed changes
@sreichel sreichel requested a review from fballiano September 21, 2022 00:55
@sreichel
Copy link
Contributor Author

Resolved conflicts.

fballiano
fballiano previously approved these changes Sep 23, 2022
View reviewed changes
@sreichel sreichel merged commit 8e9988b into OpenMage:1.9.4.x Sep 24, 2022
@sreichel sreichel deleted the workflow branch September 24, 2022 14:39
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 8e9988b. ± Comparison against base commit 47c8177.

@elidrissidev elidrissidev mentioned this pull request Sep 29, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

@tmotyl tmotyl Awaiting requested review from tmotyl

Assignees
No one assigned
Labels
environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74