Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hardcoded credit card message in checkout #2628

Merged

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented Sep 30, 2022

Description (*)

This PR will update the hardcoded message in checkout when the quote currency is different from the base one. The old message always says "Your credit card will be charged for" regardless of the payment method. I updated it with the same message from the order view in frontend that says "Grand Total to be Charged", which should be translated in language packs.

Fixed Issues (if relevant)

  1. Fixes weird hardcoded credit card message on checkout page #1953

Manual testing scenarios (*)

  1. Have at least 2 allowed currencies in a store.
  2. Set your currency to something different from the base currency (currency/options/base).
  3. Go through the checkout and you should see the new message in "Review" step.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Checkout Relates to Mage_Checkout Template : base Relates to base template Template : default Relates to base template labels Sep 30, 2022
@fballiano
Copy link
Contributor

should we add the message to some CSV?

@elidrissidev
Copy link
Member Author

It already exists, I reused it from the frontend order view.

@fballiano
Copy link
Contributor

It already exists, I reused it from the frontend order view.

great

@fballiano fballiano merged commit fb12d0f into OpenMage:1.9.4.x Sep 30, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
7 runs  5 ✔️ 2 💤 0 ❌

Results for commit fb12d0f.

@elidrissidev elidrissidev deleted the improvement/checkout-grand-total branch September 30, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Relates to Mage_Checkout Template : base Relates to base template Template : default Relates to base template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird hardcoded credit card message on checkout page
3 participants