Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated phpdocs: return $this #2751

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Updated phpdocs: return $this #2751

merged 1 commit into from
Nov 21, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 20, 2022 •
edited
Loading

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogIndex Relates to Mage_CatalogIndex Component: Core Relates to Mage_Core Component: Dataflow Relates to Mage_Dataflow Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Oauth Relates to Mage_Oauth Component: Paygate Relates to Mage_Paygate Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag labels Nov 20, 2022
@sreichel sreichel added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Nov 20, 2022
@fballiano fballiano merged commit a9bbc3b into OpenMage:1.9.4.x Nov 21, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a9bbc3b. ± Comparison against base commit 2da23d5.

@sreichel sreichel deleted the phpdoc-this branch November 22, 2022 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogIndex Relates to Mage_CatalogIndex Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: Core Relates to Mage_Core Component: Dataflow Relates to Mage_Dataflow Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Log Relates to Mage_Log Component: Oauth Relates to Mage_Oauth Component: Paygate Relates to Mage_Paygate Component: PayPal Relates to Mage_Paypal Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @kiatng