Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sort in Manage Tax Rates grid #2757

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Fixed sort in Manage Tax Rates grid #2757

merged 2 commits into from
Dec 2, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Nov 23, 2022 •
edited
Loading

Description (*)

Fixes bug described in related PR.

Related Pull Requests

  1. Closes Set constant sort order for tax rates #2720

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@sreichel sreichel changed the title Fixed sort in Fixed sort in Manage Tax Rates grid Nov 23, 2022
fballiano
fballiano previously approved these changes Nov 24, 2022
View reviewed changes
@sreichel sreichel requested a review from luigifab November 24, 2022 23:17
luigifab
luigifab previously approved these changes Dec 1, 2022
View reviewed changes
@sreichel
Merge branch '1.9.4.x' into fix/tax-rate-sort
accb6e7 
# Conflicts:
#	.github/phpstan-baseline.neon
@sreichel sreichel dismissed stale reviews from luigifab and fballiano via accb6e7 December 2, 2022 00:07
@sreichel
Copy link
Contributor Author

sreichel commented Dec 2, 2022

Just fixed conflicts ...

@fballiano fballiano merged commit efcc5f0 into OpenMage:1.9.4.x Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit efcc5f0. ± Comparison against base commit 2e5b42e.

@sreichel sreichel deleted the fix/tax-rate-sort branch December 2, 2022 13:21
@fballiano fballiano mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigifab luigifab luigifab approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @luigifab