From f726ec1b223b5de601807e0098da018832326144 Mon Sep 17 00:00:00 2001 From: Fabrizio Balliano Date: Sun, 14 May 2023 16:55:20 +0100 Subject: [PATCH 1/2] Fixed PHP8.2 deprecated warning in Mage_Cron_Model_Observer --- app/code/core/Mage/Cron/Model/Observer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/code/core/Mage/Cron/Model/Observer.php b/app/code/core/Mage/Cron/Model/Observer.php index 27fea671b0b..192ae37e4fd 100644 --- a/app/code/core/Mage/Cron/Model/Observer.php +++ b/app/code/core/Mage/Cron/Model/Observer.php @@ -220,7 +220,7 @@ public function cleanup() $now = time(); foreach ($history->getIterator() as $record) { - if (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()]) { + if (strtotime($record->getExecutedAt() ?? '') < $now - $historyLifetimes[$record->getStatus()]) { $record->delete(); } } From f9be65511f535b4923197040cf72e9293bcc0bf9 Mon Sep 17 00:00:00 2001 From: Fabrizio Balliano Date: Tue, 23 May 2023 15:35:52 +0100 Subject: [PATCH 2/2] Update app/code/core/Mage/Cron/Model/Observer.php Co-authored-by: Ng Kiat Siong --- app/code/core/Mage/Cron/Model/Observer.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/code/core/Mage/Cron/Model/Observer.php b/app/code/core/Mage/Cron/Model/Observer.php index 192ae37e4fd..c61739ac26a 100644 --- a/app/code/core/Mage/Cron/Model/Observer.php +++ b/app/code/core/Mage/Cron/Model/Observer.php @@ -220,7 +220,9 @@ public function cleanup() $now = time(); foreach ($history->getIterator() as $record) { - if (strtotime($record->getExecutedAt() ?? '') < $now - $historyLifetimes[$record->getStatus()]) { + if (empty($record->getExecutedAt()) + || (strtotime($record->getExecutedAt()) < $now - $historyLifetimes[$record->getStatus()]) + ) { $record->delete(); } }