Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added functionality for $after paramenter in addCrumbs() method #336

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Added functionality for $after paramenter in addCrumbs() method #336

merged 2 commits into from
Jan 3, 2018

Conversation

sreichel
Copy link
Contributor

In Mage_Page_Block_Html_Breadcrumbs::addCrumb() third parameter $after is ignored/has no affect ...

This should work correctly now ...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');

LeeSaferite
LeeSaferite approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@LeeSaferite LeeSaferite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix. Thanks!

I'd even go further and add a new addCrumbBefore method. I toyed with using a true value for $after to indicate it should be added to the front, but that is a bit weird in practice.

@sreichel sreichel closed this Oct 3, 2017
@sreichel sreichel reopened this Oct 3, 2017
@colinmollenhour colinmollenhour merged commit f2b0815 into OpenMage:1.9.3.x Jan 3, 2018
@sreichel sreichel deleted the feature/addCrumb-after branch January 3, 2018 19:39
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Jan 22, 2018
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
7bf1eb0 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 28, 2018
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
0006bd3 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Mar 20, 2018
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
f0823a0 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Jul 17, 2018
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
c1b831e 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Sep 19, 2018
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
bf99d77 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
@sreichel sreichel mentioned this pull request Sep 21, 2018
Closed
4 tasks
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 14, 2019
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
6aca898 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Apr 1, 2019
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
beaea12 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 22, 2019
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
ca7c66b 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Oct 25, 2019
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
458b628 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
@sreichel sreichel added the Component: Page Relates to Mage_Page label Jun 5, 2020
@sreichel sreichel mentioned this pull request Jun 20, 2020
Merged
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@sreichel @edannenberg
[bug-OpenMage#336] Mage_Page_Block_Html_Breadcrumbs::addCrumb() isn't…
bf60e63 
… fully implemented

The third parameter `$after` is ignored/has no affect...

This should work correctly now...

 $block->addCrumb('my_crumb', array(
     'label'    => label,
     'title'    => title,
 ), 'home');
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSaferite LeeSaferite LeeSaferite approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Page Relates to Mage_Page new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @colinmollenhour @LeeSaferite