Varien_Crypt_Mcrypt added PHP 7.3 support

[Sekiphp]

Added support for PHP 7.3. Removed functions are deprecated as PHP 7.1 and removed in PHP 7.2.

More info in issue #654

[Sekiphp]

ecb: https://www.php.net/manual/en/mcrypt.constants.php

[seansan]

@Sekiphp Can you explain how this works and why you closed this issue/pull?

We are having problems with CRYPT in M19.4.x LTS ... we tried the solution by @colinmollenhour #129 witht the title "If You're Typing the Word MCRYPT Into Your PHP Code, You're Doing It Wrong"

But the reality is ... people DO type the word mcrypt in their code and wont change it

So we've tried

• Nothing, upgraded to PhP 7.2 + LTS and got errors mainly in (popular!) extensions
• Implemented the fix in issue If You're Typing the Word MCRYPT Into Your PHP Code, You're Doing It Wrong #129 but then the code obfuscation stops working in vendor code + paypal express stopped working (header encodign wrong)
• maybe try this solution?

Maybe I should type this into the issue itself for a better discussion there ... #129

But the long and the short is: we need to get this fixed. And Im not an expert in any coding/decoding algoritms ... ;(

What to do

[colinmollenhour]

It is hard to pinpoint a specific example but I think this openssl method sometimes works and sometimes doesn't depending on the input and it has to do with the padding at the end of the string if I remember correctly.. It has been a while, though..