From 2ff6fe8e7a706ed1b6e835e8bda2d2fabba6ea53 Mon Sep 17 00:00:00 2001
From: Anton Todorov <a.todorov@storpool.com>
Date: Fri, 7 Feb 2020 17:41:41 +0200
Subject: [PATCH] B #4164: Use xmllint to test disk target device

Signed-off-by: Anton Todorov <a.todorov@storpool.com>
---
 src/vmm_mad/remotes/kvm/detach_disk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/vmm_mad/remotes/kvm/detach_disk b/src/vmm_mad/remotes/kvm/detach_disk
index 02d569409be..968b00bd9af 100755
--- a/src/vmm_mad/remotes/kvm/detach_disk
+++ b/src/vmm_mad/remotes/kvm/detach_disk
@@ -29,9 +29,10 @@ DETACH_PARAMS="--domain $DOMAIN --target $TARGET"
 exec_and_log "virsh --connect $LIBVIRT_URI detach-disk $DETACH_PARAMS" \
     "Could not detach $TARGET from $DOMAIN"
 
-virsh --connect $LIBVIRT_URI dumpxml $DOMAIN | grep $TARGET > /dev/null 2>&1
+virsh --connect $LIBVIRT_URI dumpxml $DOMAIN | \
+    xmllint -xpath "//disk/target[@dev='$TARGET']" - >/dev/null 2>&1
 
-if [ $? -eq 0 ] ; then
+if [ $? -ne 0 ] ; then
     error_message "Could not detach $TARGET from $DOMAIN"
     exit -1
 fi