Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deselect star when scope starts slewing while looping exposures #868

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

agalasso
Copy link
Contributor

@agalasso agalasso commented Jul 8, 2020

While looping exposures (but not guiding) poll pPointingSource to check for slewing, and deselect the guide star if slewing is detected.
The behavior is enabled only when the Stop guiding when mount slews option is enabled.

Fixes #867

@agalasso agalasso requested a review from bwdev01 July 8, 2020 05:17
Copy link
Contributor

@bwdev01 bwdev01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerned about unwanted behavior for scientific uses - e.g. fine-centering ops for spectroscopy or other things we don't know about. Overall, seems like feature has unknown downside and epsilon benefit.

@agalasso
Copy link
Contributor Author

agalasso commented Jul 8, 2020

Concerned about unwanted behavior for scientific uses

agreed. I was hoping tying the new behavior to the existing config option "Stop guiding when scope slews" would reduce the risk of unwanted side effects?

Ok, here's a scenario where this might be a problem: somebody who uses their mount's hand control set to low speed (centering speed) to nudge the mount to either take up dec backlash or to position a guide star for spectroscopy etc. In those cases de-selecting would be undesirable.

So I'm convinced now we do not want to take this PR as-is.

Another option would be to check the scope coordinates and only deselect if the coordinates differ from the starting coordinates by some minimum amount (like perhaps the size of the frame). The problem there is that a Sync operation can cause the coordinates to change by an arbitrary amount even though the scope did not move.

Maybe a combination of the two: mount slewed and coordinates changed by an amount larger then the size of the full frame?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

automatically de-select star when looping exposures if mount slews
2 participants