ppd/ppd-ipp.c: Use make when constructing printer-make-model attr #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used only PPD Nickname which does not contain manufacturer in some drivers (like Utax) when constructing printer-make-and-model IPP attribute, and then used the attribute when matching with strings representing manufacturers in filter functions. This caused internal hacks for specific printer manufacturers weren't applied, causing breakage during printing.
|
@tillkamppeter ping |
tillkamppeter
added a commit
that referenced
this pull request
Sep 21, 2023
The PPD's NickName sometimes contains manufacturer and model, sometimes only the model, not the manufacturer. And manufacturer names can be completely missing or messy. By using cfIEEE1284NormalizeMakeModel() we clean this up and have clear manufacturer names, for better answers print clients and correct application of quirk rules, especially by the ppdFilterPDFToPS() filter function. Improved solution for Pull Request #21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used only PPD Nickname which does not contain manufacturer in some drivers (like Utax) when constructing printer-make-and-model IPP attribute, and then used the attribute when matching with strings representing manufacturers in filter functions.
This caused internal hacks for specific printer manufacturers weren't applied, causing breakage during printing.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2192912 .