Integration with mosaic.js npm - 0.10.0-beta.2 #109
Conversation
…s_integration # Conflicts: # lib/helper/GnosisSafe.js # package.json # test/integration/DirectTransfer.js
pgev
left a comment
pgev
left a comment
There was a problem hiding this comment.
LGTM (we can merge), left some inline comments.
| * ABI and BIN files sit in contracts/abi, contracts/bin folder. | ||
| */ | ||
| class OpenSTAbiBinProvider extends AbiBinProvider { | ||
| /** |
There was a problem hiding this comment.
I am not sure why OpenSTAbiBinProvider is inheriting from AbiBinProvider of mosaic?
There was a problem hiding this comment.
OpenST is on top of mosaic. Inheriting AbiBinProvider of mosaic helps end users to retrieve abi/bin of mosaic with a single OpenST AbiBinProvider object.
There was a problem hiding this comment.
But should they need to? Why?
| binFolderPath = binFolderPath || DEFAULT_BIN_FOLDER_PATH; | ||
| super(abiFolderPath, binFolderPath); | ||
| constructor(abiFolderPath, binFolderPath) { | ||
| const abiDirectoryPath = abiFolderPath || DEFAULT_ABI_FOLDER_PATH; |
There was a problem hiding this comment.
DEFAULT_ABI_FOLDER_PATH and DEFAULT_BIN_FOLDER_PATH are guarded (NOT_FOR_WEB__BEGIN). Should we check that if they are undefined and abiFolderPath, binFolderPath are not passed and raise error?
There was a problem hiding this comment.
Makes sense. However I am still not sure how can DEFAULT_ABI_FOLDER_PATH, DEFAULT_BIN_FOLDER_PATH can be undefined.
Having said that once openst-contracts npm package are integrated, we will not need path dependencies .
There was a problem hiding this comment.
@abhayks1 can you please expand on that? I cannot follow.
4 participants
Integration of mosaic.js npm 0.10.0-beta.2
Fixes #76