Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I loves me a good bit-banging as much as the next guy.
(OK, that's a lie, I completely hate it and feel like, if we're fiddling with the raw, individual bits of an image, we're way too low-level and should be using better APIs or support classes.)
But I especially can't countenance
openshot::Clip()
manually applying alpha transparency in afor()
loop, immediately before it usesQPainter
to draw the resulting image... whenQPainter
has a.setOpacity()
method!!...So let's just use that, why don't we?
Edit: Also, I finally figured out what that one Codacy message was complaining about, with the
source_image
inClip::apply_keyframes
. (We were double-encapsulating the waveformQImage
in astd::shared_ptr
.) Fixed.