Bug Fix: Multiple Clips/Transitions Dropped on New Layer (#5092)

* Fix bug preventing multiple clips to be dropped on a new track/layer. * Fix regression caused by dropping multiple clips from different tracks. Also, no longer remove selection after dragging/dropping clips/transitions.
OpenShot · Jan 13, 2023 · 42135d8 · 42135d8
1 parent ffaffa1
commit 42135d8
Showing 1 changed file with 2 additions and 17 deletions.
diff --git a/src/timeline/js/directives/track.js b/src/timeline/js/directives/track.js
@@ -71,29 +71,14 @@ App.directive("tlTrack", function ($timeout) {
 
           // Get uuid to group all these updates as a single transaction
           var tid = timeline.get_uuid();
+          var drop_track_num = -1;
 
           // with each dragged clip, find out which track they landed on
           // Loop through each selected item, and remove the selection if multiple items are selected
           // If only 1 item is selected, leave it selected
           ui_selected.each(function (index) {
             var item = $(this);
 
-            // Remove all selections
-            if (ui_selected.length > 1) {
-              for (var clip_index = 0; clip_index < scope.project.clips.length; clip_index++) {
-                scope.project.clips[clip_index].selected = false;
-                if (scope.Qt) {
-                  timeline.removeSelection(scope.project.clips[clip_index].id.replace("clip_", ""), "clip");
-                }
-              }
-              for (var tran_index = 0; tran_index < scope.project.effects.length; tran_index++) {
-                scope.project.effects[tran_index].selected = false;
-                if (scope.Qt) {
-                  timeline.removeSelection(scope.project.effects[tran_index].id.replace("transition_", ""), "transition");
-                }
-              }
-            }
-
             // Determine type of item
             var item_type = null;
             if (item.hasClass("clip")) {
@@ -121,7 +106,7 @@ App.directive("tlTrack", function ($timeout) {
             }
 
             // get track the item was dropped on
-            var drop_track_num = findTrackAtLocation(scope, parseInt(item_middle, 10));
+            drop_track_num = findTrackAtLocation(scope, parseInt(item_middle, 10));
 
             // if the droptrack was found, update the json
             if (drop_track_num !== -1) {