preferences: Tweak layout builder #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code for building the preferences window layout from the available settings items was always trying to add `extraWidget` to the item's `layout_hbox`, but since `extraWidget` is only set on `param["type"] == "browse"` items, most of the time `extraWidget` is undefined. This was causing a flurry of (harmless) log messages whenever the prefs window was opened: ``` QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ QLayout: Cannot add a null widget to QHBoxLayout/ ``` This change wraps an `if(extraWidget):` around the code adding it to the layout, so it will only be attempted when it exists.
|
@ferdnyc - Nice little fix. LGTM. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for building the preferences window layout from the available settings items was always trying to add
extraWidgetto the item'slayout_hbox, but sinceextraWidgetis only set onparam["type"] == "browse"items, most of the timeextraWidgetis undefined. This was causing a flurry of (harmless) log messages whenever the prefs window was opened:This change wraps an
if(extraWidget):around the code adding it to the layout, so it will only be attempted when theextraWidgetexists.