Rewrite conversion of relative and absolute path support in OpenShot #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is is to address absolute paths burried inside the undo/redo history.
…x when the JSON is read and written to the file. This prevents lots of iterating over dicts, and is more full-proof for finding paths, even ones listed in the undo/redo history.
|
@ferdnyc This will handle undo/redo paths which point to /tmp/ mounting paths, so long as the user re-saves the project using this new code. But moving forward, all paths will always be saved relative, including those in the undo/redo history (thus supporting /tmp/ mount points and such). 👍 |
…ven happen anymore... but some older project files can still contain these keys, which can be giant blobs of data.
|
I also found another case of "bloated" undo/redo history... where we had an updateAction for "history" itself... which contained an entire clone of the history data structure. That was discovered by @peanutbutterandcrackers and also fixed in this branch. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done a complete rewrite of relative and absolute path support in OpenShot, to work as the JSON is read and write. It uses regex to quickly find all mentions of "path": or "image": , and converts the paths as needed: absolute when loading a project, and relative when saving. Even better, it also catches all paths in the undo/redo history, and fully supports @transitions relative paths.
I've done quite a bit of testing on Linux, and this seems to work much better than the previous approach. I need to now test on Windows and Mac, to verify this has no OS dependencies.