Improved Docking (Timeline widget is now dockable and Properties works in pillar mode) #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add 'Properties View' menu item * Add custom fallback icon for Properties View * Implement Properties View * Place the Timeline in a QDockWidget, other changes * Add 1-pixel-high central widget The central widget, which will auto-expand to the width of the area between the left and right dock areas, but is fixed at `1px` in height, effectively becomes part of the dual splitter handle separating the top and bottom dock areas. * Title and constrain Timeline dock * Timeline dock will now include the "Timeline" title in its titlebar * The dock is constrained to be non-closeable (only movable and resizeable) * The dock has a minimum size of `250px`×`150px`.
…nd dock settings. Also renaming the settings, to wipe out existing user preference which would make the screen go crazy on first launch (for existing users).
…sons... since I would prefer we not have to retranslate those things before our next release). Also removing "Properties View" which was a bit experimental, since we are aleady forcing Properties into pillar mode with both "simple" and "advanced" views.
|
Nice! This is now merged into develop. I will continue testing though on all OSes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @ferdnyc and @peanutbutterandcrackers for their work on this one! This update changes how OpenShot's UI docks a bit, and make things more flexible. It defaults the "Properties dock widget" to fill the entire vertical space (top to bottom) on the left side of the screen. In "Advanced" view, the properties widget uses the right side of the screen. This gives two primary docking options in our view presets. I've also updated the default window_state and window_geometry for new installs, and updated the "Simple" and "Advanced" views.