Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick 5dbb993a from release branch #3202

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Feb 3, 2020

Cherry-pick 5dbb993:

Removing verbose debug statement when getting properties for property dialog (which happens as the user scrubs the timeline)

… dialog (which happens as the user scrubs the timeline)
@SuslikV
Copy link
Contributor

SuslikV commented Feb 3, 2020

Can this be transformed to the debug log level?

Edit: There were thoughts: #2895 that there could be more that just "info" level of verbosity in the logs. But nothing changed since these posts.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 3, 2020

Merging, because this is hella annoying.

@ferdnyc ferdnyc merged commit eb7ecbb into OpenShot:develop Feb 3, 2020
@ferdnyc
Copy link
Contributor Author

ferdnyc commented Feb 3, 2020

Can this be transformed to the debug log level?

If someone implements off-by-default debug logging, sure, I suppose it could be. Though I somewhat question the usefulness of spewing out the entire property definition of every frame the user previews, even for debugging.

But, I won't disagree that we could really use another level of logging, one that defaults to disabled. Along with a command-line switch to enable it for just the current session, so you don't have to edit your settings (and then remember to turn it off again.)

@ferdnyc ferdnyc deleted the verbose-cherry branch February 3, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants