Fix Edit Title, Duplicate Title shortcut overlap with Add Track #3312
Conversation
They were both set to Ctrl+Shift+T which is also Add Track. * Set Duplicate Title to Ctrl+Shift+C (it was free), and clear the default shortcut for Edit Title. * Add both to the settings file, so they can be changed. * Rewrite context menu and selection handling in file views
|
Conflict of interests with the: #3264 |
Is it? Darn. I haven't looked at that one yet. They may be reconcilable — the stuff I touched mostly uses the We may need to shuffle some things around a bit between us, but hopefully solvable. |
|
I'm using slightly different solution for the selection - instead of Qt signal, I'm running selection update before the function that will use the results of the selection (it's only few places). Thus, some Qt events may come later if PC is busy and this is OK. |
jonoomph
changed the title
|
@ferdnyc I'm worried this might also conflict with the Emoji branch, but I'm gonna just merge it, and then reconcile the changes on the Emoji branch. Merging now. Thanks! |
A user reported that the Duplicate Title shortcut both (a) didn't work, and (b) wasn't editable. Turned out, it was set to Ctrl+Shift+T, which is a problem because so was Edit Title. Worse, neither of those actually responded to Ctrl+Shift+T, because Ctrl+Shift+T is Add Track! They also appeared nowhere in the settings file.
I managed to fix that, made them both configurable, with Duplicate Track set to Ctrl+Shift+C — it was free — and Edit Title not set by default.
As part of making the shortcuts properly react to selection in the file views, I rewrote a bunch of the selection-handling logic so it's less easily confused, and accidentally fixed #3240 in the process.
Fixes #3310
Fixes #3240