Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classes.app: Set icon, desktop file #3354

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented Apr 6, 2020

Do a couple of things to establish our application identity with various window managers, desktop session managers, etc

Fixes: #1112

@SuslikV
Copy link
Contributor

SuslikV commented Apr 6, 2020

from images import openshot_rc - is excessive check.

It seems that it works for Windows without changes. Thus, all OK.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented Apr 6, 2020

@SuslikV

Cool, thanks, I was pretty confident it was cross-platform.

from images import openshot_rc - is excessive check.

Not sure what you mean -- that import establishes the resource file for the application. When I later use QIcon(":/openshot.svg") to set the window icon, that import is what makes the :/... path resolve to the resource file.

The resource file does end up registering as an unused import, annoyingly, but that's just how PyQt set things up.

@ferdnyc ferdnyc merged commit 140466c into OpenShot:develop Apr 6, 2020
@ferdnyc ferdnyc deleted the set-desktop-file branch April 6, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShot icon is wrong under KDE Plasma Wayland session
2 participants