Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Properties: Some tweaks to raise the profile of the JSON data dump #3441

Merged
merged 1 commit into from
May 5, 2020

Conversation

ferdnyc
Copy link
Contributor

@ferdnyc ferdnyc commented May 3, 2020

  • Move the JSON text from being buried in a too-small widget stuffed at the bottom of the QToolBox, to having its own tab next to 'Details'
  • Retitle the tab/section from 'Output' to 'JSON'
  • Allow text selection via mouse AND(/or) keyboard
  • Disable hard-to-read line wrapping; the dialog can be widened

All together this has the effect of making it a realistic option to read the JSON-formatted data dump for the project file in question, a frustrating prospect with the old layout.

"Before"

(Even if you made the window larger!)
image

"After"s

image
image
image

- Move the JSON text from being buried in a too-small widget stuffed at
  the bottom of the QToolBox, to having its own tab next to 'Details'
- Retitle the tab/section from 'Output' to 'JSON'
- Allow text selection via mouse AND(/or) keyboard
- Disable hard-to-read line wrapping; the dialog can be widened
@ferdnyc ferdnyc added the interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...) label May 3, 2020
@SuslikV
Copy link
Contributor

SuslikV commented May 3, 2020

It works for W7 too.

@ferdnyc
Copy link
Contributor Author

ferdnyc commented May 4, 2020

@SuslikV Jolly good, thanks! 🧐 🎩

@ferdnyc
Copy link
Contributor Author

ferdnyc commented May 5, 2020

I'm going to merge this. I've tested it, @SuslikV has tested it, it's mostly a cosmetic change, and I can't really conceive of anyone saying they prefer the previous layout.

@ferdnyc ferdnyc merged commit 97ba981 into OpenShot:develop May 5, 2020
@ferdnyc ferdnyc deleted the file-properties-ui branch May 5, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interface GUI / user interface issues (i.e. windows, buttons, scrolling, pop-ups, etc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants