Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CTRL to multi-select timeline items (clips and transitions) #3715

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

jonoomph
Copy link
Member

Adapting from another PR (#3317), and making some changes. This adds the ability to hold CTRL to select and unselect items (clips and transitions).

…For example, if there is already a Point with coordinate X=1, remove that, and then add the new preset Point. Fixes bug where first preset keyframe was uneditable.
@jonoomph
Copy link
Member Author

I accidentally included a commit from another PR. Oops. In theory, after my previous PR is merged, this should be resolved I think.

@jonoomph jonoomph merged commit cc1735b into develop Sep 11, 2020
@jonoomph jonoomph deleted the ctrl-timeline-selections branch September 11, 2020 19:59
@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 12, 2020

On this subject, I recently filed #3716 — seems WebEngine broke Ctrl+A functionality on the Timeline.

@ferdnyc
Copy link
Contributor

ferdnyc commented Sep 16, 2020

@jonoomph

Hmm, I seem to have hit a bug in this (separate from #3716) — now if you right-click on an unselected Timeline object, it is added to the current selection. So you can accidentally keep growing the selection just by right-clicking one Clip/Transition at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants